lkml.org 
[lkml]   [2001]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Remaining net/ pci_enable_device cleanups.
Francois romieu wrote:
>
> The Wed, Feb 07, 2001 at 10:48:17PM -0500, Jeff Garzik wrote :
> [...]
> > > diff -urN --exclude-from=/home/davej/.exclude linux/drivers/net/epic100.c linux-dj/drivers/net/epic100.c
> > > --- linux/drivers/net/epic100.c Wed Feb 7 21:55:56 2001
> > > +++ linux-dj/drivers/net/epic100.c Wed Feb 7 22:15:22 2001
> >
> > applied
>
> @@ -341,7 +341,7 @@
> static int printed_version;
> long ioaddr;
> int chip_idx = (int) ent->driver_data;
> - const int irq = pdev->irq;
> + int irq;
> struct net_device *dev;
> struct epic_private *ep;
> int i, option = 0, duplex = 0;
> @@ -354,10 +354,11 @@
> printk (KERN_INFO "%s" KERN_INFO "%s" KERN_INFO "%s",
> version, version2, version3);
>
> - i = pci_enable_device(pdev);
> - if (i)
> + if (pci_enable_device(pdev))
> return i;
>
> return i ? Looks bogus to me.

Definitely bogus and I forgot to mention that I fixed this up :)

Jeff



--
Jeff Garzik | "You see, in this world there's two kinds of
Building 1024 | people, my friend: Those with loaded guns
MandrakeSoft | and those who dig. You dig." --Blondie
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:08    [W:0.032 / U:5.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site