Messages in this thread |  | | Date | Thu, 8 Feb 2001 15:02:30 -0200 (BRDT) | From | Rik van Riel <> | Subject | Re: [PATCH] micro-opt DEBUG_ADD_PAGE |
| |
On Thu, 8 Feb 2001, Hugh Dickins wrote: > On Thu, 8 Feb 2001, David Weinehall wrote: > > > > Well, after all, it's debugging code, and the code now is easy to read. > > Your code, while more efficient, isn't. I think that clarity takes > > priority over efficiency in non-critical code such as debugging > > code. Of course, this is my personal opinion... > > I agree my version isn't _as_ easy, and if this code only got built > into DEBUG kernels, I would never have bothered about it; but it's > built into every kernel, on executed paths, so it's no less critical.
Since it's DEBUG code only and nicely "hidden" in a .h file, why not have the efficient code with a well-written comment documenting what the code does and why it is there ?
regards,
Rik -- Linux MM bugzilla: http://linux-mm.org/bugzilla.shtml
Virtual memory is like a game you can't win; However, without VM there's truly nothing to lose...
http://www.surriel.com/ http://www.conectiva.com/ http://distro.conectiva.com/
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |