Messages in this thread | | | Date | Wed, 28 Feb 2001 11:41:07 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: NBD Cleanup patch and bugfix in ll_rw_blk.c |
| |
On Sun, 25 Feb 2001, Steve Whitehouse wrote: > > Here is a new version of the patch I recently sent to the list with some > NBD cleanups and a bug fix in ll_rw_blk.c. The changes to NBD have Pavel > Machek's approval as I've left out the two changes as he suggested. > > The bug fix in ll_rw_blk.c prevents hangs when using block devices which > don't have plugging functions,
I'm convinced that the right fix is to just make everybody have plugging functions.
Right now, who doesn't? The fix is unbelievably ugly, AND can break real drivers that _do_ have plugging functions (where they get surprised by having their request function called several times per plug just because somebody unplugged them and new requests came in).
Just fix ndb instead.
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |