lkml.org 
[lkml]   [2001]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] patch-2.4.2-irda1 (irda-usb)
On Tue, Feb 27, 2001 at 08:29:03AM +0000, Dag Brattli wrote:
> Linus,
>
> Please apply this patch to your latest Linux-2.4.2 source. Changes:
>
> o IrDA-USB dongle support [new feature]

I'd recommend that this file be in the /drivers/usb directory, much like
almost all other USB drivers are.

> +/* These are the currently known IrDA USB dongles. Add new dongles here */
> +struct irda_usb_dongle dongles[] = { /* idVendor, idProduct, idCapability */
> + /* ACTiSYS Corp, ACT-IR2000U FIR-USB Adapter */
> + { 0x9c4, 0x011, IUC_SPEED_BUG | IUC_NO_WINDOW },
> + /* KC Technology Inc., KC-180 USB IrDA Device */
> + { 0x50f, 0x180, IUC_SPEED_BUG | IUC_NO_WINDOW },
> + /* Extended Systems, Inc., XTNDAccess IrDA USB (ESI-9685) */
> + { 0x8e9, 0x100, IUC_SPEED_BUG | IUC_NO_WINDOW },
> + { 0, 0, 0 }, /* The end */
> +};

You should also probably add the following snippet to allow the USB
hotplug functionality to work properly:

static __devinitdata struct usb_device_id id_table [] = {
{ USB_DEVICE(0x09c4, 0x0011) },
{ USB_DEVICE(0x050f, 0x0180) },
{ USB_DEVICE(0x08e9, 0x0100) },
{ } /* Terminating entry */
};
MODULE_DEVICE_TABLE (usb, id_table);

If IRDA has a class descriptor, can't you just rely on that, and not
have to worry about the individual device vendor and product ids?


> + * This routine is called by the USB subsystem for each new device
> + * in the system. We need to check if the device is ours, and in
> + * this case start handling it.
> + * Note : it might be worth protecting this function by a global
> + * spinlock...
> +static void *irda_usb_probe(struct usb_device *dev, unsigned int ifnum,
> + const struct usb_device_id *id)

A spinlock is not needed as the probe functions are called sequentially.


thanks,

greg k-h

--
greg@(kroah|wirex).com
http://immunix.org/~greg
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:22    [W:0.089 / U:2.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site