lkml.org 
[lkml]   [2001]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch] 2.4.2: irq-driven lp stalls
Hi Linus,

This patch seems to cure some printing stalls that some people have
been seeing. The down_trylock call isn't really needed there anyway.

Please apply.

Tim.
*/

2001-02-27 Tim Waugh <twaugh@redhat.com>

* drivers/parport/ieee1284_ops.c: Remove down_trylock call,
which seems to prevent stalls.
* drivers/parport/ChangeLog: Updated.

--- linux/drivers/parport/ieee1284_ops.c.sema Tue Feb 27 21:43:49 2001
+++ linux/drivers/parport/ieee1284_ops.c Tue Feb 27 21:44:16 2001
@@ -50,9 +50,6 @@
if (port->irq != PARPORT_IRQ_NONE) {
parport_enable_irq (port);
no_irq = 0;
-
- /* Clear out previous irqs. */
- while (!down_trylock (&port->physport->ieee1284.irq));
}

port->physport->ieee1284.phase = IEEE1284_PH_FWD_DATA;
--- linux/drivers/parport/ChangeLog.sema Tue Feb 27 21:44:21 2001
+++ linux/drivers/parport/ChangeLog Tue Feb 27 21:45:43 2001
@@ -0,0 +1,7 @@
+2001-02-27 Tim Waugh <twaugh@redhat.com>
+
+ * ieee1284_ops.c (parport_ieee1284_write_compat): Don't use
+ down_trylock to reset the IRQ count. Don't even use sema_init,
+ because it's not even necessary to reset the count. I can't
+ remember why we ever did.
+
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-03-22 13:28    [W:0.025 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site