Messages in this thread | | | Date | Mon, 26 Feb 2001 18:06:32 +0300 | From | Andrey Panin <> | Subject | Re: [PATCH] drivers/char/serial.c unchecked ioremap() calls |
| |
On Fri, Feb 23, 2001 at 09:15:29AM -0500, Jeff Garzik wrote: > Arnaldo Carvalho de Melo wrote: > > > > Em Fri, Feb 23, 2001 at 10:53:59AM +0300, Andrey Panin escreveu: > > > > > > Hi all, > > > > > > 16x50 serial driver doesn't check ioremap() return value. > > > Atached patch should fix this it. > > > > humm, have not checked, but it seems as if you don't release the previous > > successful mappings on failure. Wipe out this message if I was too quick to > > answer and this is not true. 8) > > Also, the proper return from a failed ioremap is -ENOMEM, so I think > Andrey's serial.c patch should modify some functions to return a failure > code... >
All these ioremap() failures are not fatal, just fail to init one PCI/ISAPNP device or one serial port. IMHO a warning message will be enough for them :)
-- Andrey Panin | Embedded systems software engineer pazke@orbita1.ru | PGP key: http://www.orbita1.ru/~pazke/AndreyPanin.asc [unhandled content-type:application/pgp-signature] | |