Messages in this thread Patch in this message | | | Date | Mon, 19 Feb 2001 04:17:06 -0600 (CST) | From | Philipp Rumpf <> | Subject | Re: kernel_thread() & thread starting |
| |
On Sun, 18 Feb 2001, Kenn Humborg wrote: > in the .config, I can get schedule_task() to fail with: > > schedule_task(): keventd has not started
This shouldn't be a failure case, just a (bogus) printk.
> When starting bdflush and kupdated, bdflush_init() uses a semaphore to > make sure that the threads have run before continuing. Shouldn't > start_context_thread() do something similar?
Why bother ? It looks like a leftover debugging message which doesn't make a lot of sense once the code is stable (what might make sense is checking keventd is still around, but that's not what the code is doing).
Proposed patch:
--- linux-2.4/kernel/context.c Fri Jan 12 18:52:41 2001 +++ linux-prumpf/kernel/context.c Mon Feb 19 11:11:37 2001 @@ -26,19 +26,9 @@ static int keventd_running; static struct task_struct *keventd_task; -static int need_keventd(const char *who) -{ - if (keventd_running == 0) - printk(KERN_ERR "%s(): keventd has not started\n", who); - return keventd_running; -} - int current_is_keventd(void) { - int ret = 0; - if (need_keventd(__FUNCTION__)) - ret = (current == keventd_task); - return ret; + return current == keventd_task; } /** @@ -57,7 +47,6 @@ int schedule_task(struct tq_struct *task) { int ret; - need_keventd(__FUNCTION__); ret = queue_task(task, &tq_context); wake_up(&context_task_wq); return ret; dwmw2 ?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |