Messages in this thread |  | | Subject | Re: [PATCH] pcnet32.c: MAC address may be in CSR registers | | Date | Thu, 15 Feb 2001 16:49:49 +0000 (GMT) | | From | Alan Cox <> |
| |
> Peter pointed out that the contents of the CSR12-14 registers are > initialized from the EEPROM, so reading the EEPROM is superfluous--we > should just read the CSRs and not read the EEPROM. I think he has a > point, so I'll make that change and submit yet another patch pair.
I'd rather keep the existing initialisation behaviour of using the eeprom for 2.2. There are also some power management cases where I am not sure the values are restored on the pcnet/pci.
For 2.2 conservatism is the key. For 2.4 by all means default to CSR12-14 and print a warning if they dont match the eeprom value and we'll see what it shows
> Alan, do you want me to put your inline version in <linux/etherdevice.h> > while I'm at it, or what?
Sure - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |