Messages in this thread | | | Date | Wed, 14 Feb 2001 06:00:51 -0600 (CST) | From | Jeff Garzik <> | Subject | Re: [PATCH] network driver updates |
| |
On Wed, 14 Feb 2001, Manfred Spraul wrote: > * something is wrong in the vortex initialization: I don't have such a > card, but the driver didn't return an error message on insmod. I'm not > sure if > my fix is correct.
> @@ -2661,9 +2661,12 @@ > > rc = pci_module_init(&vortex_driver); > if (rc < 0) { > - rc = vortex_eisa_init(); > - if (rc > 0) > + int rc2; > + rc2 = vortex_eisa_init(); > + if (rc2 > 0) { > vortex_have_eisa = 1; > + rc = 0; > + } > } else { > vortex_have_pci = 1; > }
IMHO vortex should be trying to initialize EISA regardless of the results of the PCI probe... Andrew?
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |