lkml.org 
[lkml]   [2001]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.4.2-pre3 compile error in 6pack.c
    Alan Cox wrote:
    >
    > > Do you really prefer if drivers contain a
    > >
    > > static inline void* safe_kmalloc(size, flags)
    > > {
    > > if(size > LIMIT)
    > > return NULL;
    > > return kmalloc(size, flags);
    > > }
    >
    > It isnt that simple. Look at af_unix.c for example. It needs to know the
    > maximum safe request size to set values up and is prepared to accept
    > smaller values if that fails
    >

    Ok, I just downloaded -ac9.

    Hmm.
    What about removing -16 instead of increasing it to 64?
    The slab allocator is perfect for power of 2 allocations!
    The slab descriptors are stored outside in seperate buffers.

    And why KMALLOC_SIZE/2?
    "Keep 2 messages in ..."?


    Btw, sock_alloc_send_skb() (net/core.c) still uses the wrong allocation
    mode for "size":

    GFP_BUFFER both sleeps and uses the atomic queue.

    skb = alloc_skb(size, sk->allocation & (~__GFP_WAIT));

    --
    Manfred
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:17    [W:0.030 / U:0.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site