Messages in this thread |  | | Date | Sat, 10 Feb 2001 10:34:13 -0500 | From | Tom Leete <> | Subject | Re: [PATCH] Athlon-SMP compiles & runs. inline fns honored. |
| |
Manfred Spraul wrote: > > Tom Leete wrote: > > > > + > > +#ifndef _LINUX_MM_H > > +struct vm_area_struct; > > +#endif > > + > Are the #ifndef's necessary? > Could you try to remove the #ifndef and always declare the struct? gcc > shouldn't complain.
Probably not necessary, but that seemed tidier if the struct definition is available.
> > > + > > +/* Try removing /linux/fs.h in capability.h first > > +#ifndef _LINUX_CAPABILITY_H > > +typedef struct bogus_cap_struct { > > + __u32 cap; > > +} kernel_cap_t; > > +#endif > > +*/ > > + > Is is possible to get rid of that one? > What if somone modifies capability.h?
Yes, that's provisional and is superfluous if 'capability.h:17 #include <linux/fs.h>' is to be removed. It is commented out in the preliminary patch. Awaiting comment from the authors.
> > -- > Manfred
After critique is in, I'll make a polished final version.
Thanks for the review, Tom
-- The Daemons lurk and are dumb. -- Emerson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/
|  |