Messages in this thread | | | From | Keith Owens <> | Subject | Re: Linux 2.4.17-pre5 / Have fun with make | Date | Sat, 08 Dec 2001 09:21:36 +1100 |
| |
On Fri, 7 Dec 2001 17:39:54 +0100, Stephan von Krawczynski <skraw@ithnet.com> wrote: >On Sat, 08 Dec 2001 00:35:14 +1100 >Keith Owens <kaos@ocs.com.au> wrote: >> >> CFLAGS_foo.o += -DMAX_CARDS=$(subst (,,$(subst ),,$(CONFIG_HISAX_MAX_CARDS))) >> >> In foo.c, use MAX_CARDS instead of CONFIG_HISAX_MAX_CARDS. Change foo >> to the name of the object that you are working on. When you build, it >> should say -DMAX_CARDS=8. > >Keith, it is getting weird right now. Your above suggestion does not work, it >does not even execute, because the braces obviously confuse it.
That's what I get for typing code late at night and not testing it. The correct implementation of that line is probably
lp:=( rp:=)
CFLAGS_foo.o += -DMAX_CARDS=$(subst $(lp),,$(subst $(rp),,$(CONFIG_HISAX_MAX_CARDS)))
But as you found, you don't need that anyway.
>Now I come up with a _working_ solution, but to be honest, I don't dare to give >away the patch, because it looks like this: > >EXTRA_CFLAGS += -DHISAX_MAX_CARDS=$(subst ,,$(CONFIG_HISAX_MAX_CARDS))
EXTRA_CFLAGS += -DHISAX_MAX_CARDS=$(CONFIG_HISAX_MAX_CARDS)
will work just as well. The reason that you do not get '(8)' that way is because CML1 generates inconsistent output. In .config the line says CONFIG_HISAX_MAX_CARDS=8, in include/linux/autoconf.h it says #define CONFIG_HISAX_MAX_CARDS (8). The makefiles use .config, the source code uses autoconf.h.
Inconsistency of inconsistencies, saith the preacher; all is inconsistency.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |