lkml.org 
[lkml]   [2001]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] 2.4.16: kmalloc tidying
Date
From
> +++ linux-2.4.16/drivers/sbus/char/envctrl.c	Tue Nov 13 05:31:02 2001
> @@ -897,10 +897,6 @@ static void envctrl_init_i2c_child(struc
> }
> =20
> pchild->tables =3D kmalloc(tbls_size, GFP_KERNEL);
> - if (!pchild->tables) {
> - printk("envctrl: Failed to get table, not enough memory.\n");

Why are you removing the checks here ?

> current->mm->rss =3D 0;
> - setup_arg_pages(bprm); /* XXX: check error */
> + retval =3D setup_arg_pages(bprm);
> + if (retval)=20
> + goto out_free_dentry;

At this point you need to do more drastic things - see the last -ac patch
for a possible solution
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.052 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site