lkml.org 
[lkml]   [2001]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] link errors with internal calls to devexit functions
    On Sat, Dec 22, 2001 at 01:57:25PM +1100, Jason Thomas wrote:
    > please CC me I'm not on the list.
    >
    > This patch against 2.4.17 fixes internal calls to devexit functions (which
    > is bypasses the devexit_p wrapper) in drivers/media/video/bttv-driver.c and
    > drivers/usb/usb-uhci.c, they are the only two I found.
    >
    > diff -ur linux-2.4.17.orig/drivers/media/video/bttv-driver.c linux-2.4.17/drivers/media/video/bttv-driver.c
    > --- linux-2.4.17.orig/drivers/media/video/bttv-driver.c Sat Dec 22 13:39:39 2001
    > +++ linux-2.4.17/drivers/media/video/bttv-driver.c Sat Dec 22 13:46:02 2001
    > @@ -2992,7 +2992,9 @@
    > pci_set_drvdata(dev,btv);
    >
    > if(init_bt848(btv) < 0) {
    > +#if defined(MODULE) || defined(CONFIG_HOTPLUG)
    > bttv_remove(dev);
    > +#endif

    These changes are incorrect... if a remove function is called during the
    init phase it should never have been marked __devexit in the first
    place.

    Jeff


    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:14    [W:0.025 / U:32.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site