lkml.org 
[lkml]   [2001]   [Dec]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] 2.4.17 compile error + fix
Date
On 22 Dec 2001 22:28:56 -0600, 
Phil Brutsche <pbrutsch@tux.creighton.edu> wrote:
>diff -urN linux/drivers/usb/usb-uhci.c
>linux-2.4.17-modified/drivers/usb/usb-uhci.c
>--- linux/drivers/usb/usb-uhci.c Fri Dec 21 11:41:55 2001
>+++ linux-2.4.17-modified/drivers/usb/usb-uhci.c Sat Dec 22
>22:10:27 2001
>@@ -3001,7 +3001,7 @@
> s->irq = irq;
>
> if(uhci_start_usb (s) < 0) {
>- uhci_pci_remove(dev);
>+ __devexit_p (uhci_pci_remove(dev));
> return -1;
> }
>
>The resulting kernel boots fine on a PII; there are no problems with
>hot-plugging USB devices.
>
>Marcelo, please consider for 2.4.18.

Do not apply, the code is wrong, uhci_pci_remove is called from
mainline code. If the mainline code is correct then uhci_pci_remove
must not be defined as __devexit/__devexit_p. If uhci_pci_remove is
not supposed to be called then the mainline code has to be changed. In
either case, it is a job for the uhci maintainer.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:14    [W:0.043 / U:10.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site