lkml.org 
[lkml]   [2001]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH][RFC 3] cleaning up struct sock
Em Thu, Dec 20, 2001 at 12:21:26AM -0800, David S. Miller escreveu:
> From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
> Date: Thu, 20 Dec 2001 01:23:39 -0200
>
> Available at:
>
> http://www.kernel.org/pub/linux/kernel/people/acme/v2.5/2.5.1/
> sock.cleanup-2.5.1.patch.bz2
>
> Looking pretty good. I have one improvement.
>
> I'd rather you pass the "kmem_cache_t" directly into sk_alloc, use
> NULL for "I don't have any extra private area".

humm I did that with sock_register to avoid changing all the sk_alloc
users, but in the end all protocols were changed so... ok, I'll do that, at
least it'll simplify the "rtnetlink socket allocated early in the boot
process before sock_register(rtnetlink) was called".

> And then, for the IP case lay it out like this:
>
> struct sock
> struct ip_opt
> struct {tcp,raw4,...}_opt
>
> And use different kmem_cache_t's for each protocol instead of
> the same one for tcp, raw4, etc.
>
> RAW/UDP sockets waste a lot of space with your current layout.

*grin*

Ok, ok, lets save more bytes 8) I'll look into this.

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:14    [W:0.088 / U:3.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site