Messages in this thread |  | | Date | Thu, 20 Dec 2001 00:21:26 -0800 (PST) | Subject | Re: [PATCH][RFC 3] cleaning up struct sock | From | "David S. Miller" <> |
| |
From: Arnaldo Carvalho de Melo <acme@conectiva.com.br> Date: Thu, 20 Dec 2001 01:23:39 -0200
Available at:
http://www.kernel.org/pub/linux/kernel/people/acme/v2.5/2.5.1/ sock.cleanup-2.5.1.patch.bz2
Looking pretty good. I have one improvement.
I'd rather you pass the "kmem_cache_t" directly into sk_alloc, use NULL for "I don't have any extra private area".
And then, for the IP case lay it out like this:
struct sock struct ip_opt struct {tcp,raw4,...}_opt
And use different kmem_cache_t's for each protocol instead of the same one for tcp, raw4, etc.
RAW/UDP sockets waste a lot of space with your current layout. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |