lkml.org 
[lkml]   [2001]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] direct IO breaks root filesystem

On Mon, 10 Dec 2001, GOTO Masanori wrote:
>
> The reason is that when kernel accesses /dev/sda with O_DIRECT,
> blkdev_direct_IO() is called. But, it calls generic_direct_IO(),
> and generic_direct_IO() calls brw_kiovec(..., inode->i_dev, ...).

That's a bad bug, yes.

However, the bug is really in "generic_direct_IO()", and you should fix it
there, instead of avoiding to use it altogether.

"generic_direct_IO()" should just get the device from "bh->b_dev (which is
filled in correctly by "get_block()".

Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:14    [W:0.279 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site