lkml.org 
[lkml]   [2001]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: NULL pointer dereference in moxa driver
On 10 Dec 2001 18:53:48 +0100
Christian Laursen <xi@borderworlds.dk> wrote:

> I have a problem when trying to use two of the serial cards known as
> MOXA C104H/PCI.
>
> When only using one, everything works like a charm, but when
> an attempt is made to access a serial port on the second card,
> I get a NULL pointer dereference.
>
>
> This is the relevant output from dmesg:
>
> MOXA Smartio family driver version 1.2
> Tty devices major number = 174, callout devices major number = 175
> Found MOXA C104H/PCI series board(BusNo=0,DevNo=10)
>
>
> The relevant stuff from /proc/pci:
>
> Bus 0, device 10, function 0:
> Serial controller: Moxa Technologies Co Ltd Smartio C104H/PCI (rev 2).
> IRQ 10.
> I/O at 0xa800 [0xa87f].
> I/O at 0xa400 [0xa43f].
> I/O at 0xa000 [0xa00f].
> Bus 0, device 11, function 0:
> Serial controller: Moxa Technologies Co Ltd Smartio C104H/PCI (#2) (rev 2).
> IRQ 11.
> I/O at 0x9800 [0x987f].
> I/O at 0x9400 [0x943f].
> I/O at 0x9000 [0x900f].

Well there you have it: they didn't recognise the second board at all. The dmesg should show it, but does not.
Please try attached patch to mxser.c. I cannot test, I have no two cards (in fact I haven't a single one either ;-). If it works out tell me and send patch to support@moxa.com.tw with regards from me :-)

Have fun,
Stephan


--- linux/drivers/char/mxser.c-orig Mon Dec 10 19:29:13 2001
+++ linux/drivers/char/mxser.c Mon Dec 10 19:34:36 2001
@@ -614,9 +614,9 @@
n = (sizeof(mxser_pcibrds) / sizeof(mxser_pcibrds[0])) - 1;
index = 0;
for (b = 0; b < n; b++) {
- pdev = pci_find_device(mxser_pcibrds[b].vendor,
- mxser_pcibrds[b].device, pdev);
- if (!pdev || pci_enable_device(pdev))
+ while (pdev = pci_find_device(mxser_pcibrds[b].vendor,
+ mxser_pcibrds[b].device, pdev)) {
+ if (pci_enable_device(pdev))
continue;
hwconf.pdev = pdev;
printk("Found MOXA %s board(BusNo=%d,DevNo=%d)\n",
@@ -646,6 +646,7 @@

}

+ }
}
}
#endif


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:14    [W:0.070 / U:3.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site