Messages in this thread |  | | Subject | Re: [PATCH] if (foo) kfree(foo) /fs cleanup + reverted JBD code path changes | From | OGAWA Hirofumi <> | Date | Sun, 02 Dec 2001 02:14:15 +0900 |
| |
Zwane Mwaikambo <zwane@linux.realnet.co.sz> writes:
> out_fail: > - if (opts.iocharset) { > - printk("FAT: freeing iocharset=%s\n", opts.iocharset); > - kfree(opts.iocharset); > - } > - if(sbi->private_data) > - kfree(sbi->private_data); > + printk("FAT: freeing iocharset=%s\n", opts.iocharset);
In all failed cases, this message will be outputted. I think I shouldn't do so. (or remove this message.)
> + kfree(opts.iocharset); > + > + kfree(sbi->private_data); > sbi->private_data = NULL; -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |