Messages in this thread |  | | Date | Sat, 01 Dec 2001 07:49:21 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] if (foo) kfree(foo) /fs cleanup |
| |
Alan Cox wrote: > > IMHO this is precisely the wrong thing to do. > > We should make the = NULL check within kfree do a BUG() call. That way we > fix the cases not being considered instead of hiding real bugs
I actually agree with the general sentiment, but,
Then you have to fix all the code which has assumed such, breaking previously-correct code. bcrl (IIRC) was the one who told me about kfree doing the NULL check; likewise akpm for brelse. So people are using these things.
Do you really want to audit every single kfree and brelse to implement this change?
-- Jeff Garzik | Only so many songs can be sung Building 1024 | with two lips, two lungs, and one tongue. MandrakeSoft | - nomeansno
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |