This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Wed Dec 6 22:23:49 2023 Received: from spaans.ds9a.nl (adsl-xs4all.ds9a.nl [213.84.159.51]) by kylie.puddingonline.com (8.11.6/8.11.6) with SMTP id g8IFkmX19177 for ; Wed, 18 Sep 2002 17:46:48 +0200 Received: (qmail 23234 invoked from network); 18 Sep 2002 07:05:26 -0000 Received: from unknown (HELO spaans.ds9a.nl) (3ffe:8280:10:360:202:44ff:fe2a:a1dd) by mayo.ipv6.ds9a.nl with SMTP; 18 Sep 2002 07:05:26 -0000 Received: (qmail 1243 invoked by uid 1000); 17 Sep 2002 20:44:08 -0000 Received: (maildatabase); juh Received: (qmail 6008 invoked by alias); 9 Nov 2001 10:03:24 -0000 Received: (qmail 6005 invoked from network); 9 Nov 2001 10:03:23 -0000 Received: from vvtp.tn.tudelft.nl (HELO vvtp.nl) (qmailr@::ffff:130.161.252.29) by spaans.ds9a.nl with SMTP; 9 Nov 2001 10:03:23 -0000 Received: (qmail 31058 invoked by uid 2547); 9 Nov 2001 10:03:21 -0000 Received: (qmail 30975 invoked from network); 9 Nov 2001 10:03:20 -0000 Received: from vger.kernel.org (199.183.24.194) by vvtp.tn.tudelft.nl with SMTP; 9 Nov 2001 10:03:20 -0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 9 Nov 2001 05:00:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 9 Nov 2001 05:00:38 -0500 Received: from mail.loewe-komp.de ([62.156.155.230]:64521 "EHLO mail.loewe-komp.de") by vger.kernel.org with ESMTP id ; Fri, 9 Nov 2001 05:00:24 -0500 Received: from loewe-komp.de (pippin.loewe-komp.de [192.168.169.19]) by mail.loewe-komp.de (8.11.0/8.11.0/SuSE Linux 8.11.0-0.4) with ESMTP id fA9A3sS19709; Fri, 9 Nov 2001 11:03:54 +0100 X-Authentication-Warning: mail.loewe-komp.de: Host pippin.loewe-komp.de [192.168.169.19] claimed to be loewe-komp.de Message-Id: <3BEBA93F.80B0A7E1@loewe-komp.de> Date: Fri, 09 Nov 2001 11:00:31 +0100 From: Peter =?iso-8859-1?Q?W=E4chtler?= Organization: LOEWE. Hannover X-Mailer: Mozilla 4.76 [de] (X11; U; Linux 2.4.9-ac3 i686) X-Accept-Language: de, en Mime-Version: 1.0 To: linux-xfs@oss.sgi.com Cc: lkml Subject: NFS hit me (2.4.9-xfs) again References: <1005258455.4701.4.camel@itspec.amoa.org> <1005258497.9075.22.camel@jen.americas.sgi.com> <1005259546.5742.9.camel@itspec.amoa.org> <1005261542.9077.29.camel@jen.americas.sgi.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org X-AntiVirus: scanned for viruses by AMaViS 0.2.1 (http://amavis.org/) X-AntiVirus: scanned for viruses by AMaViS 0.2.1 (http://amavis.org/) X-Spam-Tag: 1 Lines: 95 Unable to handle kernel NULL pointer dereference at virtual address 00000000 00000000 *pde = 00000000 Oops: 0000 CPU: 0 EIP: 0010:[<00000000>] Using defaults from ksymoops -t elf32-i386 -a i386 EFLAGS: 00010286 eax: 00000000 ebx: c9c0d7e0 ecx: 00000000 edx: c03a7b00 esi: c9c0d560 edi: c9c0d7e0 ebp: c9c0d7e0 esp: cbddde84 ds: 0018 es: 0018 ss: 0018 Process nfsd (pid: 233, stackpage=cbddd000) Stack: c01729f4 cc97f420 c9c0d560 00000005 cdc40a00 c0172e56 c9c0d7e0 00000005 cd390200 cd390000 cbed2000 cbdddf20 cdc40be8 cd390200 c0173199 cdc40a00 cd390010 00000005 00000001 00000001 00000008 cbe17e00 cbee48c0 cd390200 Call Trace: [] [] [] [] [] [] [] [] [] [] Code: Bad EIP value. >>EIP; 00000000 Before first symbol Trace; c01729f4 Trace; c0172e56 Trace; c0173199 Trace; c0173ad2 Trace; c017843d Trace; c017173c Trace; c0171003 Trace; c0240318 Trace; c0170dab Trace; c010557f This is not the initial crash location - the machine was dead (and no serial console yet). But after restarting, about 6-10 clients tried to reconnect to NFSD and caused the crash. The crash appears because "child->d_inode->i_op->lookup == NULL" struct dentry *nfsd_findparent(struct dentry *child) { struct dentry *tdentry, *pdentry; tdentry = d_alloc(child, &(const struct qstr) {"..", 2, 0}); if (!tdentry) return ERR_PTR(-ENOMEM); /* I'm going to assume that if the returned dentry is different, then * it is well connected. But nobody returns different dentrys do they? */ /* added safety check to prevent crash - peewee */ if (child->d_inode->i_op && child->d_inode->i_op->lookup){ pdentry = child->d_inode->i_op->lookup(child->d_inode, tdentry); } else { printk("normally we had been crashing\n"); printk("child: %p\n",child); printk("child->d_inode: %p\n",child->d_inode); printk("child->d_inode->i_op: %p\n",child->d_inode->i_op); printk("child->d_inode->i_op->lookup: %p\n",child->d_inode->i_op->lookup); return( ERR_PTR(-EINVAL) );  } d_drop(tdentry); /* we never want ".." hashed */ if (!pdentry && tdentry->d_inode == NULL) { /* File system cannot find ".." ... sad but possible */ dput(tdentry); ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ ^ this one was removed in 2.4.10 pdentry = ERR_PTR(-EINVAL); } if (!pdentry) { /* I don't want to return a ".." dentry. * I would prefer to return an unconnected "IS_ROOT" dentry, [...] If I use 2.4.12-xfs (with nfs-utils 0.3.3), clients can't create an archive with "ar": [ strace output of "ar" creating a lib out of several *.o] write(5, "\0\0\1\2\0\0H\2\0\0\1\2\0\0L\2\0\0\1\2\0\0P\2\0\0\1\2\0"..., 3254) = 3 close(5) = 0 munmap(0x4001f000, 4096) = 0 lstat64("lumenuila.a", {st_mode=S_IFREG|0644, st_size=8, ...}) = 0 rename("stO1wjGV", "lumenuila.a") = -1 ESTALE (Stale NFS file handle) My main question is: Is it possible that some interaction with xfs<->nfsd causes this kind of trouble? Especially when lookup("..") fails - and dealing with "disconnected dentries". Does the nfs_fh carry not enough information ( when is oldfh used, when the newer one? [ref_fh->fh_handle.fh_version == 0xca]). So we have an inode with no proper inode_operations, huh? I don't use NFSv3, should I? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/