[lkml]   [2001]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] lp.c, eexpress.c jiffies cleanup
    On Nov 06, 2001  21:37 +0000, Philip Blundell wrote:
    > In message <>, Andreas Dilger writes:
    > >I agree. It seems very ugly. I looked at a few drivers which loop 1 or 2
    > >jiffies, but to busy-loop for 1/10th of a second, or even 20 seconds
    > >is terribly bad.
    > Those timeouts are only a last resort. If the card is working properly
    > the loop will terminate much sooner.

    Well, if the card is working properly, then you don't need the timeouts
    at all. Clearly, if they are needed, then either they should be more
    realistic in length (1/10th isn't bad, but 20 seconds?), or after a
    "reasonable" short timeout, it should sleep for an interval and check
    afterwards. Sucking all CPU for 20 seconds and locking everything else
    out isn't an acceptable method IMHO.

    Cheers, Andreas
    Andreas Dilger

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-03-22 13:12    [W:0.029 / U:61.084 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site