Messages in this thread | | | Date | Mon, 5 Nov 2001 18:14:47 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: 2.4.14 doesn't compile: deactivate_page not defined in loop.c |
| |
On Tue, 6 Nov 2001, Andrea Arcangeli wrote: > > no idea why deactivate_page disappeared, it made sense to deactivate the > lower level cache
Answer me this:
How would it get activated in the first place?
Right. By being accessed multiple times, that's how. Which you claim it won't be - in which case de-activating it is a no-op, and unnecessary.
Now, there's another possibility: that it _does_ get accessed multiple times, _despite_ being the lower-level cache. In which case de-activating it is the wrong thing to do.
So we basically have two cases. And in neither case does it make sense to de-activate the page. Eh?
Linus
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |