[lkml]   [2001]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[Patch] Serial lockup fixed
After installing any serial-5.00 or later in kernels 2.2.18, 19 or 20,
rs_init is entered twice. This results in the serial timer being added
twice, which corrupts the timer list and causes an infinite loop. The
symptom is a complete hang on boot, usually just after the "Freeing
unused kernel memory" message.

Pre 18 the call path is do_basic_setup() -> device_setup() ->
chr_dev_setup() -> tty_init() -> rs_init().

In 2.4.x rs_init is entered with the module_init() (__initcall) magic.

The attached is for 2.2.20, and simply removes the tty_init() ->
rs_init() path. This mimics 2.4.x.

There might be an issue; do_initcalls() is slightly later in
do_basic_setup() than device_setup(), but the in between code looks
similar to 2.4.x kernels so I don't think it's a problem delaying the
serial init.

I'll post the slightly less elegant hack to the serial driver that
compensates for the broken kernels shortly.

Patch status is: Works For Me. Testers needed.



diff -ru linux-2.2.20/drivers/char/tty_io.c
--- linux-2.2.20/drivers/char/tty_io.c Fri Nov 2 11:39:06 2001
+++ linux-2.2.20-serial-init-fix/drivers/char/tty_io.c Mon Nov 5 22:03:54
@@ -2189,9 +2189,6 @@
#ifdef CONFIG_ESPSERIAL /* init ESP before rs, so rs doesn't see the port
- rs_init();

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:12    [W:0.037 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site