lkml.org 
[lkml]   [2001]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [LART] pc_keyb.c changes


On Fri, 30 Nov 2001, Alexander Viro wrote:

> Could the person who switched from BKL to spin_lock_irqsave() in
> pc_keyb.c please share whatever the hell he had been smoking? Free clue:
> disabling interrupts for long intervals to improve scalability is right up
> there with fighting for peace and fucking for virginity.
>
> Linus, could we please revert that crap and feed the authors to
> Larry? If they are religious about Scalability At Any Cost, Common Sense
> Be Damned(tm) - let's give them a chance to become martyrs...

BTW, while we are at it, one is _not_ supposed to do inclusion to/removal from
single-linked list without any exclusion whatsoever. Example:
drivers/input/evdev.c::evdev_{open,release}(). Or drivers/input/joydev.c
and drivers/input/mousedev.c, for that matter. Sigh...

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.096 / U:1.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site