lkml.org 
[lkml]   [2001]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch] smarter atime updates
From
Date
Andrew Morton <akpm@zip.com.au> writes:

> OGAWA Hirofumi wrote:
> >
> > #define UPDATE_ATIME(inode) \
> > do { \
> > if ((inode)->i_atime != CURRENT_TIME) \
> > update_atime (inode); \
> > } while (0)
> >
>
> yes, that'd be fine. The more conventional approach
> would be to blow away the strange UPPER CASE name and:
>
> static inline void update_atime(struct inode *inode)
> {
> if (inode->i_atime != CURRENT_TIME)
> __update_atime(inode);
> }
>
> But that would be a bigger patch, and I rather like shaving
> off three quarters of the sys_read() overhead with a two-liner ;)

Umm, I think only fs/autofs4/root.c use update_atime() directly.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:18    [W:0.115 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site