lkml.org 
[lkml]   [2001]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Coding style - a non-issue
Date
Followup to:  <20011130140613.F14710@work.bitmover.com>
By author: Larry McVoy <lm@bitmover.com>
In newsgroup: linux.dev.kernel
> >
> > A simple rule to remember is: when code is bad, criticize the code, not the
> > coder.
>
> Your priorities are upside down. The code is more important than the
> coder, it will outlive the coder's interest in that code. Besides,
> this isn't some touchy feely love fest, it's code. It's suppose to
> work and work well and be maintainable. You don't get that by being
> "nice", you get that by insisting on quality. If being nice worked,
> we wouldn't be having this conversation.
>

So the sensible thing to do is, again, to criticize the code, not the
coder.

There are multiple reasons for that:

a) The code is what counts.
b) People take personal attacks, well, personally. It causes
unnecessary bad blood.
c) There are people who will produce beautiful code one minute, and
complete shitpiles the next one.

If a certain piece of code is a shitpile, go ahead and say so. Please
do, however, explain why that is, and please give the maintainer a
chance to listen before being flamed publically.

-hpa
--
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
http://www.zytor.com/~hpa/puzzle.txt <amsp@zytor.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.251 / U:2.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site