lkml.org 
[lkml]   [2001]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] remove BKL from drivers' release functions
Date
From
I think you're exactly the right person to be helping out with this;
glad to see you join the discussion.

The biggest flaw in the patch was not realizing that chrdev_open held
the BKL for us during opens as well. I don't think that invalidates it
in its entirety though. In cases where the patch replaced BKL with
some other form of locking, we should be no worse off (but for your
concerns about scheduling) because we added it in the open routines
too. In cases where we removed BKL from release but noted there were
"still" locking issues, yes, we need to examine those closely and fix
them in case we've created a locking issue where none existed before.

In most (all?) cases, the spinlocks are held briefly and (we believe)
not across scheduling opportunities. If you see areas of the patch
where that is not true, I agree they should be addressed and please point
them out.

Rick
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.089 / U:9.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site