lkml.org 
[lkml]   [2001]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectAdaptec vs Symbios performance
Hello Justin, hello Gerard                                            

I am looking currently for reasons for bad behaviour of aic7xxx driver
in an shared interrupt setup and general not-nice behaviour of the
driver regarding multi-tasking environment.
Here is what I found in the code:

/*
* SCSI controller interrupt handler.
*/
void
ahc_linux_isr(int irq, void *dev_id, struct pt_regs * regs)
{
struct ahc_softc *ahc;
struct ahc_cmd *acmd;
u_long flags;

ahc = (struct ahc_softc *) dev_id;
ahc_lock(ahc, &flags);
ahc_intr(ahc);
/*
* It would be nice to run the device queues from a
* bottom half handler, but as there is no way to
* dynamically register one, we'll have to postpone
* that until we get integrated into the kernel.
*/
ahc_linux_run_device_queues(ahc);
acmd = TAILQ_FIRST(&ahc->platform_data->completeq);
TAILQ_INIT(&ahc->platform_data->completeq);
ahc_unlock(ahc, &flags);
if (acmd != NULL)
ahc_linux_run_complete_queue(ahc, acmd);
}

This is nice. I cannot read the complete code around it (it is derived
from aic7xxx_linux.c) but if I understand the naming and comments
correct, some workload is done inside the hardware interrupt (which
shouldn't), which would very much match my tests showing bad overall
performance behaviour. Obviously this code is old (read the comment)
and needs reworking.
Comments?

Regards,
Stephan

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:12    [W:0.089 / U:3.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site