lkml.org 
[lkml]   [2001]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.5.1-pre2 does not compile
On Nov 28, 2001  13:55 +0100, Christoph Hellwig wrote:
> > > While we are at breaking scsi, would you take a patch to remove the
> > > old-style (2.0) scsi error handling completly, forcing drivers still
> > > using it to be fixed? Early 2.5 looks like a good time for that to me..
>
> --- ../master/linux-2.5.1-pre2/drivers/scsi/aic7xxx_old/aic7xxx.h Sun Mar 4 23:30:18 2001
> +++ linux/drivers/scsi/aic7xxx_old/aic7xxx.h Wed Nov 28 13:35:21 2001
> @@ -55,7 +55,6 @@
> present: 0, /* number of 7xxx's present */\
> unchecked_isa_dma: 0, /* no memory DMA restrictions */\
> use_clustering: ENABLE_CLUSTERING, \
> - use_new_eh_code: 0 \
> }
>
> extern int aic7xxx_queue(Scsi_Cmnd *, void (*)(Scsi_Cmnd *));

What would be nice in the case of drivers that don't use the new error
handling code is to add something like:

#warning "Uses obsolete SCSI error code, see Documentation/2.5/scsi-error.txt"

for a hint as to the reason why it no longer compiles, and a short guide
on how to update the drivers.

The same would be good for Jens' changes - his document could be put into
2.5/bio.txt or something, so any currently out-of-kernel coders can find it.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.090 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site