[lkml]   [2001]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subjectip_queue_xmit2 inconsistency regarding skb->sk

I posted a kernel oops related to netfilter/REDIRECT. It seems like
ip_queue_xmit2 crashes on (skb->sk == NULL) in calling

ip_dont_fragment(sk, &rt->u.dst)

which can't handle the (sk == NULL) situation. Of course there is the matter of
why (sk == NULL) in the first place. Haven't figured that out yet, nf_hook_slow
may cause do this somehow.

The other matter however is wether or not ip_queue_xmit2 should be able to
handle the (skb->sk == NULL) situation. The code is not consistent on that

It seems like the if statement:

if (skb_headroom(skb) < dev->hard_header_len && dev->hard_header) {

handles the (sk == NULL) situation, given the line "if (sk)". Other parts of
ip_queue_xmit2 seem to assume (sk != NULL), like the ip_dont_fragment call
or lines like "skb->priority = sk->priority".

OK, this is not the answer on the why of the kernel oops. I hope however that
this question is related and helps in finding the answer

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2005-03-22 13:18    [W:0.027 / U:2.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site