lkml.org 
[lkml]   [2001]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectPatch for fdomain driver.

I've been using my old Quantum ISA-200S fdomain-based scsi-card to
drive my zipdrive for a few years now, and when I upgraded to 2.4,
I got an Oops.

After much testing, I found the fdomain driver to be the culprit,
especially the readb() calls.

Since this is a ISA card, those should apparently rather be isa_readb()
instead.

There might be more changes needed, but it works for me now.

/Per Larsson.

--
Democracy is the working model of any form of mob rule. The fruit of
democracy, if unchecked by respect for human rights, is gang violence.
Always! -- http://www.unquietmind.com/mislaid_iv.html
--- /tmp/foo/fdomain.c.orig Sun Sep 30 21:26:07 2001
+++ drivers/scsi/fdomain.c Tue Nov 27 23:59:59 2001
@@ -729,13 +729,13 @@
switch (Quantum) {
case 2: /* ISA_200S */
case 3: /* ISA_250MG */
- base = readb(bios_base + 0x1fa2) + (readb(bios_base + 0x1fa3) << 8);
+ base = isa_readb(bios_base + 0x1fa2) + (isa_readb(bios_base + 0x1fa3) << 8);
break;
case 4: /* ISA_200S (another one) */
- base = readb(bios_base + 0x1fa3) + (readb(bios_base + 0x1fa4) << 8);
+ base = isa_readb(bios_base + 0x1fa3) + (isa_readb(bios_base + 0x1fa4) << 8);
break;
default:
- base = readb(bios_base + 0x1fcc) + (readb(bios_base + 0x1fcd) << 8);
+ base = isa_readb(bios_base + 0x1fcc) + (isa_readb(bios_base + 0x1fcd) << 8);
break;
}

@@ -1955,7 +1955,7 @@
offset = bios_base + 0x1f31 + drive * 25;
break;
}
- memcpy_fromio( &i, offset, sizeof( struct drive_info ) );
+ isa_memcpy_fromio( &i, offset, sizeof( struct drive_info ) );
info_array[0] = i.heads;
info_array[1] = i.sectors;
info_array[2] = i.cylinders;
\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.026 / U:1.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site