lkml.org 
[lkml]   [2001]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subject2 questions (block_dev.c / buffer.c)
From
Date
Hi,

I've gor two short question regarding the changes that got into the kernel
since
about 2.4.14 (I think)

1. block_dev.c (blkdev_get())
This function doesn't increment the refrence count for the bdev via
acquire_inode (or bdget). The error path in do_open as well as
blkdev_put however decrease the count.
Shouldn't there be an acquire_inode(bdev->bd_inode) ?

2. buffer.c (invalidate_bdev())
This now prints a message whenever bh->bd_count is not 0.
However this is always the case when doing an BLKFLSBUF
ioctl on a device with an mount FS on it.
(All the reported buffer heads belong AFAICS to the super block
data of the filesystem)
This seemed to be the case before (just silently ignored) so I guess
it is not a terribly bad thing. But its a bit anoying and may lead to
suspect
errors at the wrong end...
Was the intention to complain always like now or just in the destroy
case?

Regards,
Stefan Bader


Linux for eServer development
Stefan.Bader@de.ibm.com
----------------------------------------------------------------------------------

When all other means of communication fail, try words.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.025 / U:24.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site