lkml.org 
[lkml]   [2001]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] [PATCH] omnibus header cleanup, certification
Nathan Myers wrote:

>>
> Please review at least the portion that you are responsible for,
> and verify that the changes are safe and cannot change the semantics
> of otherwise-correct code that uses the affected macros. (That will
> be easy, they're all trivial parenthesizations. It seems worth noting
> here that in the C grammar, "-1" is not a numeric literal, but a unary
> expression.) Then, pass on your evaluation to Linus and Marcelo.
>


It's also worth noting that there is nothing that it can get confused
with and still have a compilable expression.

I don't believe the unary-expression patches are necessary. They are,
of course, harmless, except for the fact that my eyes glazed over
staring at page after page of these, which very few actual potential (!)
bugs (there were a couple, like the iopage+ ones...)

-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.065 / U:4.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site