lkml.org 
[lkml]   [2001]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Remove needless BKL from release functions
Date
On Monday 26 November 2001 18:46, David C. Hansen wrote:

> In the patch, in the open function, you do this:
> if (handler)
> new_fops = fops_get(handler->fops);
>
> But, the fops_get() #define already cheecks to make sure handler isn't
> null: #define fops_get(fops) \
> (((fops) && (fops)->owner) \
> ? ( try_inc_mod_count((fops)->owner) ? (fops) : NULL ) \
> : (fops))

Look closer, it doesn't check 'handler' (it couldn't).

--
Ciao,
Flavio Stanchina
Trento - Italy

"The best defense against logic is ignorance."
http://spazioweb.inwind.it/fstanchina/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.091 / U:2.648 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site