lkml.org 
[lkml]   [2001]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.4.15-pre9 breakage (inode.c)
On Sat, Nov 24, 2001 at 02:06:32AM -0500, Alexander Viro wrote:
>
>
> On Sat, 24 Nov 2001, Andrea Arcangeli wrote:
>
> > this one looks even better (and it doesn't need to propagate the fix to
> > the lowlevel):
> >
> > --- 2.4.15aa1/fs/super.c.~1~ Fri Nov 23 08:21:01 2001
> > +++ 2.4.15aa1/fs/super.c Sat Nov 24 07:58:37 2001
> > @@ -470,6 +470,7 @@
> > return s;
> >
> > out_fail:
> > + invalidate_inodes(s);
>
> Sigh...
> a) grep, please.
> b) you are triggering method calls for a superblock after failed
> ->read_super(). Blindly. Care to audit all filesystems and check that
> it is legitimate?

if the method or the s_op isn't defined it will do nothing, if it is
defined it'd better do something not wrong because the fs just did an
iget within read_super. I don't see obvious troubles and the above looks
better than making iput more complex (and nitpicking slower 8).

Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.069 / U:10.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site