Messages in this thread |  | | Date | Fri, 23 Nov 2001 15:43:09 +0100 | From | "J.A. Magallon" <> | Subject | Re: [BUG] Bad #define, nonportable C, missing {} |
| |
On 20011123 vda wrote: >On Thursday 22 November 2001 18:08, J.A. Magallon wrote: >> On 20011122 Stevie O wrote: >> >If we were going to be semiobscure, wouldn't the correct code be >> > >> >#define MODINC(x,y) (x = ++x % y) >> >> But the question is: Is this kind of code worth the discussion ? AFAIK, > >It worth fixing. That macro is really bad: as you can see, people cannot
That was my point, don't ever try to guess if it does what it is intended to do, just change it.
-- J.A. Magallon # Let the source be with you... mailto:jamagallon@able.es Mandrake Linux release 8.2 (Cooker) for i586 Linux werewolf 2.4.15-pre9 #1 SMP Thu Nov 22 16:16:54 CET 2001 i686 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |