Messages in this thread |  | | From | (Oliver Neukum) | Subject | Re: [PATCH] Remove needless BKL from release functions | Date | Fri, 23 Nov 2001 12:24:32 +0100 |
| |
Am Freitag 23 November 2001 11:47 schrieb Christoph Hellwig: > In article <Pine.SOL.4.33.0111231106530.7403-100000@sun3.lrz-muenchen.de> you wrote: > > While this is doubtlessly true, please don't do things like removing the > > lock from interfaces like the call to open() in the input subsystem. > > People may depend on the lock being held there. Having open() under BKL > > simplifies writing USB device drivers. > > Beeing completly single-threaded also simplifies writing unclean drivers..
This is true. However USB drivers have to cope with devices becoming unplugged at all times. The races this produces are not nice.
> BTW, I've attached a patch that fixes the largest input races (against > 2.4.6), I don't see how to change the total lack of locking for other data > structures without an API change, though.
This looks very good. Could you get this to the maintainer ?
Regards Oliver
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |