lkml.org 
[lkml]   [2001]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Remove needless BKL from release functions
Date
> Many of these patches simply remove the BKL from the file.  This causes
> no harm because the BKL was not really protecting anything, anyway.
> Other patches try to actually fix the locking. Some do this by making
> use of atomic operations with the atomic_* functions, or the
> (test|set)_bit functions. Most of these patches replace uses of normal
> integers which were used to keep open counts in the drivers. In other
> some cases, a spinlock was added when the atomic operations could not
> guarantee proper serialization by themselves. And, in very few cases,
> the existing locking was extended to protect more things. These cases
> are very uncommon because locking is very uncommon in most of these
> drivers.

At least some of the removals in the input tree are probably wrong. You are
introducing a race with deregistering of input devices.

Regards
Oliver
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.067 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site