lkml.org 
[lkml]   [2001]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] fix compile warnings in 2.4.15pre9
From
Date
On Thu, 2001-11-22 at 18:54, Andreas Dilger wrote:
> How about something like (not real patches, but you get the idea:
>
> @@ -4691,6 +4691,7 @@
> OUTL_DSP (SCRIPTA_BA (np, clrack));
> +out_stuck:
> return;
> -out_stuck:
> }
>
> @@ -5226,6 +5227,7 @@
>
> +fail:
> return;
> -fail:
> }

Yes, much better. Besides looking better, gcc _may_ generate different
code (I don't know how smart it is in this case) that has these "fall
throughs" and that would mean (a) less code and (b) less jumps -- always
a win.

Robert Love


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:18    [W:0.054 / U:5.556 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site