Messages in this thread |  | | Date | Fri, 16 Nov 2001 13:41:12 -0800 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH] AMD SMP capability sanity checking. |
| |
Dave- A couple of minor comments below.
~Randy
Dave Jones wrote: > > Note, this code will not stop you from continuing to use unsupported > configurations, but will.. > a. Print a boot time warning. > b. Taint any oopses so that SMP problem oopses can be isolated easily. > > I repeat, there is *no* loss of functionality. > > Patch against 2.4.15pre5 follows. > > diff -urN --exclude-from=/home/davej/.exclude linux-2.4.15-pre5/arch/i386/kernel/smpboot.c linux-2.4.15-pre5-dj/arch/i386/kernel/smpboot.c > --- linux-2.4.15-pre5/arch/i386/kernel/smpboot.c Fri Oct 5 01:42:54 2001 > +++ linux-2.4.15-pre5-dj/arch/i386/kernel/smpboot.c Fri Nov 16 21:09:33 2001 > + printk (KERN_INFO "WARNING: This combination of AMD processors is not suitable for SMP.\n"); > + tainted |= (1<<2);
Some bit #defines for <tainted> would be nice (instead of magic numbers).
> diff -urN --exclude-from=/home/davej/.exclude linux-2.4.15-pre5/kernel/panic.c linux-2.4.15-pre5-dj/kernel/panic.c > --- linux-2.4.15-pre5/kernel/panic.c Sun Sep 30 19:26:08 2001 > +++ linux-2.4.15-pre5-dj/kernel/panic.c Fri Nov 16 20:46:17 2001 > @@ -103,6 +103,10 @@ > /** > * print_tainted - return a string to represent the kernel taint state. > * > + * 'P' - Proprietory module has been loaded. > + * 'F' - Module has been forcibly loaded. > + * 'S' - SMP with CPUs not designed for SMP. > + * > * The string is overwritten by the next call to print_taint(). > */ > > @@ -112,7 +116,8 @@ > if (tainted) { > snprintf(buf, sizeof(buf), "Tainted: %c%c", >>>>>>>>>>>>>>>>>> %c%c%c <<<<<<<<<<<<<
> tainted & 1 ? 'P' : 'G', > - tainted & 2 ? 'F' : ' '); > + tainted & 2 ? 'F' : ' ', > + tainted & 4 ? 'S' : ' '); > } > else > snprintf(buf, sizeof(buf), "Not tainted"); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |