lkml.org 
[lkml]   [2001]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [CFT][PATCH] pci/proc.c cleanup
From
   From: Alexander Viro <viro@math.psu.edu>
Date: Thu, 15 Nov 2001 01:01:45 -0500 (EST)

It works here and applies both to 2.4.15-pre* and 2.4.13-ac*.
Please, test - it's pretty straightforward and if there is no complaints
I'm submitting that for inclusion into the tree.

I like this patch but I would change one thing.

"start,next,stop" sound like global kernel helper functions, not PCI
SEQ specific helpers, why not name them pci_seq_start et al. instead?

That pci_devices list does need locking, particularly with the PCI hot
plug stuff in the tree now. But PCMCIA could already change the list
after boot too if I'm not mistaken.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [from the cache]
©2003-2011 Jasper Spaans