lkml.org 
[lkml]   [2001]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: elvtune fails with DAC960 and devfs on 2.4.14
On Tue, Nov 13 2001, Dave Jones wrote:
> On Tue, 13 Nov 2001, Brian Ristuccia wrote:
>
> > I can't seem to adjust the elevator parameters for this block device, but
> > can't:
> > # elvtune /dev/rd/disc0/disc
> > ioctl get: Invalid argument
>
> DAC960.c doesn't know about BLKELVSET / BLKELVGET, and control is
> only passed down to the generic ioctl in the case of BLKBSZSET,
> and doesn't have a default: entry in the switch statement of
> DAC960_IOCTL()
>
> I've not seen one of these devices, so I'm not sure if this makes
> sense or not, but passing on requests to the lower level should
> be a simple..
>
> default:
> return( blk_ioctl(Inode->i_rdev, Request, Argument));
>
> Addition.

Or just add it to the BLKBSZGET etc string that pass it on to blk_ioctl
anyways.

> There may be other reasons this driver doesn't provide the
> elevator ioctls though.

None, it was simply never added.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:13    [W:0.054 / U:3.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site