Messages in this thread |  | | From | Keith Owens <> | Subject | Re: [RFT] final cur of tr based current for -ac8 | Date | Sun, 11 Nov 2001 09:54:48 +1100 |
| |
On Sat, 10 Nov 2001 17:33:31 -0500, Benjamin LaHaise <bcrl@redhat.com> wrote: >diff -ur kernels/2.4/v2.4.13-ac8/arch/i386/kernel/nmi.c v2.4.13-ac8+tr.4/arch/i386/kernel/nmi.c >--- kernels/2.4/v2.4.13-ac8/arch/i386/kernel/nmi.c Tue Nov 6 20:43:22 2001 >+++ v2.4.13-ac8+tr.4/arch/i386/kernel/nmi.c Sat Nov 10 14:00:33 2001 >@@ -264,7 +264,7 @@ > /* > * NMI can interrupt page faults, use hard_get_current. > */ >- int sum, cpu = hard_get_current()->processor; >+ int sum, cpu = hard_smp_processor_id(); > > sum = apic_timer_irqs[cpu];
I am still unhappy with that NMI code. The NMI handler can use generic code including printk, the generic code will use the standard get_current. Why does nmi.c not do set_current(hard_get_current());
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |