Messages in this thread |  | | Date | Tue, 9 Oct 2001 09:34:25 +0200 | From | Jan Kara <> | Subject | Re: Quotactl change |
| |
Hello,
> Al - is the attached patch more along the lines of what you > were after? > > Jan - I think this is actually alot closer to what you were > talking about when we last discussed this. Can you see any > problems from a VFS quota point of view here? I had to make > small interface changes to a couple of the dquot.c routines > to make this simpler/more uniform in places - could you have > cross-check those for me? I see two problems:
1) You changed interface do dquot_sync() - so you should also change DQUOT_SYNC() macro in quotaops.h (rename argument) and all callers of DQUOT_SYNC() macro...
2) It seems to me that validate_quotactl() will actually never return superblock - instead of 'ret = 0;' there should be 'return sb;' and that test 'if (ret)' should be removed....
Honza - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |