lkml.org 
[lkml]   [2001]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2.4.11-pre5] atomic_dec_and_lock() for alpha
On Mon, Oct 08, 2001 at 07:42:57PM +0400, Ivan Kokshaysky wrote:
> + " ret\n"

I am extremely uncomfortable with you returning out of the middle of
an asm statement. What if the compiler decides to allocate a stack
frame for some reason? You'll return without deallocating it.

Please write the whole thing in assembly or avoid the early return.


r~
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:04    [W:0.123 / U:1.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site