lkml.org 
[lkml]   [2001]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] spurious swap_list_unlock
On Mon, 8 Oct 2001, Andrea Arcangeli wrote:
> On Sun, Oct 07, 2001 at 01:35:58AM +0200, Andrea Arcangeli wrote:
> > On Thu, Oct 04, 2001 at 10:57:09PM +0200, Andrea Arcangeli wrote:
> > > 2) Hugh's locking cleanups
> >
> > checked now (of course it's just in pre4), very nice.
>
> btw, while playing with the code I now noticed a swap_list_unlock
> leftover in vmscan.c.

Eek, that's not at all nice! Many thanks for spotting it,
and for your review, Andrea. I'll check it all over again.
For others' sake, patch for 2.4.11-pre5 or 2.4.11-pre4 below.

Hugh

--- 2.4.11-pre5/mm/vmscan.c Sun Oct 7 20:54:29 2001
+++ linux/mm/vmscan.c Mon Oct 8 09:32:13 2001
@@ -139,7 +139,6 @@
}

/* No swap space left */
- swap_list_unlock();
set_pte(page_table, pte);
UnlockPage(page);
return 0;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:04    [W:0.051 / U:1.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site