lkml.org 
[lkml]   [2001]   [Oct]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Quotactl change


On Sat, 6 Oct 2001, Jan Kara wrote:

> Hello,
>
> I'm sending you a change for quotactl interface which Nathan Scott proposed
> for XFS. Actually it's his patch with just a few changes from me.
> It allows quotactl() to be overidden by a filesystem and so XFS can do it's
> tricks with quota without patching dquot.c. Sideeffect of this change is a
> cleanup in quotactl() interface :).

[snip]

Umm... So you've just given to each fs driver a syscall with
completely unspecified arguments? I _really_ doubt that it's a good
idea, especially since each instance will have to copy structures
to/from userland.

Please, put switch by the first argument and copy_{to,from}_user()
into the syscall itself. Yes, it means more methods, but it helps to avoid
large PITA couple of years down the road.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 13:04    [W:0.117 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site