Messages in this thread Patch in this message |  | | Date | Fri, 5 Oct 2001 13:39:22 +0200 | From | Abraham vd Merwe <> | Subject | DRM bugfix |
| |
Hi!
I found a small bug in drm_proc.h. DRM(_vm_info) tries to access dev->maplist, but dev->maplist is only intitialized when the device is opened, so if you do a cat /proc/dri/0/vm just after you load any DRM module (just before loading X), you'll get an oops and mess up the whole proc system in the process...
I've attached a fix for it. The patch is against the 2.4.10 kernel, but I think drm_proc.h in the 2.4.10 kernel is the same as in the DRI CVS repository.
--
Regards Abraham
One can never consent to creep when one feels an impulse to soar. -- Helen Keller
__________________________________________________________ Abraham vd Merwe - 2d3D, Inc.
Device Driver Development, Outsourcing, Embedded Systems
Cell: +27 82 565 4451 Snailmail: Tel: +27 21 761 7549 Block C, Antree Park Fax: +27 21 761 7648 Doncaster Road Email: abraham@2d3d.co.za Kenilworth, 7700 Http: http://www.2d3d.com South Africa
diff -Nrup linux-2.4.10.orig/drivers/char/drm/drm_proc.h linux-2.4.10/drivers/char/drm/drm_proc.h --- linux-2.4.10.orig/drivers/char/drm/drm_proc.h Wed Aug 15 23:21:47 2001 +++ linux-2.4.10/drivers/char/drm/drm_proc.h Fri Oct 5 13:33:54 2001 @@ -186,7 +186,7 @@ static int DRM(_vm_info)(char *buf, char DRM_PROC_PRINT("slot offset size type flags " "address mtrr\n\n"); i = 0; - list_for_each(list, &dev->maplist->head) { + if (dev->maplist != NULL) list_for_each(list, &dev->maplist->head) { r_list = (drm_map_list_t *)list; map = r_list->map; if(!map) continue;[unhandled content-type:application/pgp-signature] |  |